Skip to content

refactor(sysreport): drop unused run() helper and LINES_LIMIT knob - #38

Merged
developerz-ai[bot] merged 1 commit into
mainfrom
dz/delete-sysreport-s-unused-run-helper-and-its--9e5bd6fc
Nov 9, 2026
Merged

refactor(sysreport): drop unused run() helper and LINES_LIMIT knob#38
developerz-ai[bot] merged 1 commit into
mainfrom
dz/delete-sysreport-s-unused-run-helper-and-its--9e5bd6fc

Conversation

@developerz-ai

@developerz-ai developerz-ai Bot commented Nov 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What

run() was never called and LINES_LIMIT was never set. Sections keep their own printf/head pipelines; no behaviour change.

Acceptance

  • share/tools/sysreport has no run() definition and no LINES_LIMIT reference (grep returns nothing)
  • bash -n share/tools/sysreport passes; shellcheck is clean if available
  • The sec() helper and every section body are unchanged, so output is byte-identical apart from timestamp and host data
  • bash .github/run-tests.sh stays green

Changes

  • share/tools/sysreport (edit) — Delete the unused run() helper (lines 15-19, including the LINES_LIMIT default) and nothing else. Keep sec() on line 14 and the blank line before the header printf. No bug is visible in the removed lines beyond their being dead code, so there is nothing else to fix. Leave the section bodies untouched.

Verification

No check command was found for this repository, so no gate ran before the commit.

What the editors ran to see the change working, and what they saw:

  • bash -n share/tools/sysreport && grep -c 'run()\|LINES_LIMIT' share/tools/sysreport (sysreport): exit 0, count 0; sec() and the blank line before the header printf remain

Notes

Premises of the request the team disproved:

  • The request says to fix any bug visible in the removed lines. run() at share/tools/sysreport:15-19 has no real bug (the label printf and the head -n pipeline are correct), so deleting it is the whole change.

🤖 Opened by developerz.ai for task tsk_9e5bd6fc58d94ae01c729f2ba8d59f3a on developerz-ai/mini.

Raised automatically by the raw_task_triage lane.

🤖 developerz.ai, an automated agent, not a human — this PR is one slice of a stacked plan.
Dispatched automatically by the raw_task_triage lane
Model claude-sonnet-5-5 on router.ai.developerz.ai via native, funded by account_key
Ran on box hv-dedicated-ci-0
Cost unknown: no list price on record for claude-sonnet-5-5 on router.ai.developerz.ai
Run timeline run_116466f2d8074d2fb68f77f5eda9acdd
Part 1/1 of plan rtk_92c81397ee454f5991913e2011f8c066

@developerz-ai
refactor(sysreport): drop unused run() helper and LINES_LIMIT knob
0f45ca4 
run() was never called and LINES_LIMIT was never set. Sections keep their own printf/head pipelines; no behaviour change.

Dz-Task-Id: tsk_9e5bd6fc58d94ae01c729f2ba8d59f3a
@developerz-ai developerz-ai Bot added dz/fleet-pr Opened by developerz.ai, an automated agent, from a fleet run. dz/model:claude-sonnet-5-5 developerz.ai: model that wrote this bot PR. dz/provider:router.ai.developerz.ai developerz.ai: provider that served this bot PR. labels Nov 9, 2026
@developerz-ai

developerz-ai Bot commented Nov 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

✅ Reviewed — nothing blocking

0 actionable comment(s) · grounded on your code

⚠️ 1 config note(s): test files were not shown to the reviewer — this diff touched no path recognised as a test, so no assertion was available to read the change against

⏱ 26s wall clock · deepseek-v4.1-flash via router · 1 model call(s) · 565 output token(s)

🤖 developerz.ai — automated review, running on your model and your box.

developerz-ai[bot]
developerz-ai Bot commented Nov 9, 2026
View reviewed changes

@developerz-ai developerz-ai Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary — 1 file(s), 0 finding(s).

Removes the uncalled run() helper and its LINES_LIMIT default from share/tools/sysreport; the shown file has no remaining reference or call site to either, and section output is untouched. No defect found.

  • test files were not shown to the reviewer — this diff touched no path recognised as a test, so no assertion was available to read the change against

🤖 developerz.ai review — automated, running on your model and your box. What is this? · Reviewed by router/deepseek-v4.1-flash on box hv-dedicated-ci-0 — 14k in / 565 out over 1 call, on your flat-rate plan: no per-token charge (~<$0.01 at list price).

@developerz-ai
developerz-ai Bot merged commit 2eb6af9 into main Nov 9, 2026
3 checks passed
@developerz-ai
developerz-ai Bot deleted the dz/delete-sysreport-s-unused-run-helper-and-its--9e5bd6fc branch November 9, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dz/fleet-pr Opened by developerz.ai, an automated agent, from a fleet run. dz/model:claude-sonnet-5-5 developerz.ai: model that wrote this bot PR. dz/provider:router.ai.developerz.ai developerz.ai: provider that served this bot PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

0 participants